personal-projects/leo-claude-mktplace
Template
0
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(cmdb-assistant): correct NetBox API URL format in setup wizard #132

Merged
lmiranda merged 1 commits from fix/issue-126-netbox-url-format into development 2026-01-23 22:54:14 +00:00
Conversation 0 Commits 1 Files Changed 1 +6 -2
lmiranda commented 2026-01-23 22:52:52 +00:00
Owner
Copy Link

Summary

  • Fix /initial-setup command generating incorrect NETBOX_API_URL (missing /api suffix)
  • Update example URL to include /api
  • Add instruction to auto-append /api if user forgets
  • Fix validation test to be consistent with actual MCP server usage

Root Cause

The setup wizard asked for base URL (https://netbox.company.com) but NetBoxClient expects API URL (https://netbox.company.com/api). The validation test incorrectly added /api/ making it pass, while the actual MCP server failed with JSON parsing errors.

Test Plan

  • Run /cmdb-assistant:initial-setup on a fresh system
  • Verify generated netbox.env has URL with /api suffix
  • Verify MCP tools work after setup

Fixes #126

🤖 Generated with Claude Code

## Summary - Fix `/initial-setup` command generating incorrect `NETBOX_API_URL` (missing `/api` suffix) - Update example URL to include `/api` - Add instruction to auto-append `/api` if user forgets - Fix validation test to be consistent with actual MCP server usage ## Root Cause The setup wizard asked for base URL (`https://netbox.company.com`) but `NetBoxClient` expects API URL (`https://netbox.company.com/api`). The validation test incorrectly added `/api/` making it pass, while the actual MCP server failed with JSON parsing errors. ## Test Plan - [ ] Run `/cmdb-assistant:initial-setup` on a fresh system - [ ] Verify generated `netbox.env` has URL with `/api` suffix - [ ] Verify MCP tools work after setup Fixes #126 🤖 Generated with [Claude Code](https://claude.ai/claude-code)
lmiranda added 1 commit 2026-01-23 22:52:52 +00:00
fix(cmdb-assistant): correct NetBox API URL format in setup wizard dafa8db8bb 
The /initial-setup command was generating NETBOX_API_URL without the
/api suffix, causing all MCP tools to fail with JSON parsing errors.

Changes:
- Update example URL to include /api suffix
- Add instruction to auto-append /api if user forgets
- Fix validation test to be consistent with actual usage

Root cause: Setup asked for base URL (https://netbox.company.com) but
NetBoxClient expects API URL (https://netbox.company.com/api). The
validation test incorrectly added /api/ making it pass, while the
actual MCP server failed.

Fixes #126

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lmiranda merged commit 1cf1dbefb8 into development 2026-01-23 22:54:14 +00:00
lmiranda deleted branch fix/issue-126-netbox-url-format 2026-01-23 22:54:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Component/API
API endpoints, contracts, and integration
 Component/Auth
Authentication and authorization
 Component/Backend
Backend service code and business logic
 Component/Database
Database schemas, migrations, queries
 Component/Deploy
Deployment, infrastructure, DevOps
 Component/Docs
Documentation and guides
 Component/Frontend
User interface and client-side code
 Component/Infra
Infrastructure and system configuration
 Component/Testing
Test infrastructure and frameworks
 Tech/Docker
Docker containers and compose
 Tech/FastAPI
FastAPI backend framework
 Tech/JavaScript
JavaScript/Node.js code
 Tech/PostgreSQL
PostgreSQL database
 Tech/Python
Python language and libraries
 Tech/Redis
Redis cache and pub/sub
 Tech/Vue
Vue.js frontend framework
Complexity/Complex
High uncertainty or many dependencies
 Complexity/Medium
Some unknowns or dependencies
 Complexity/Simple
Straightforward, well-understood
 Effort/L
3-5 days
 Effort/M
1-2 days
 Effort/S
2-4 hours
 Effort/XL
> 1 week
 Effort/XS
< 2 hours
 Priority/Critical
Immediate attention required
 Priority/High
Important, needs attention soon
 Priority/Low
Nice to have, can wait
 Priority/Medium
Normal priority
 Type/Bug
Something isn't working
 Type/Chore
Maintenance tasks
 Type/Documentation
Documentation improvements
 Type/Feature
New feature or request
 Type/Refactor
Code refactoring without changing behavior
 Type/Test
Testing related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lmiranda
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: personal-projects/leo-claude-mktplace#132
Delete Branch "fix/issue-126-netbox-url-format"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?