lmiranda
9044fe28ec
Test Fixes: - Fix mock_config fixture to use 'owner/repo' format (was separate fields) - Update test_client_initialization to match current client API - Add required 'org' argument to get_org_labels, list_repos, aggregate_issues tests - Update error message assertion in test_no_repo_specified_error - Fix test_create_issue to mock is_org_repo and label resolution - Update aggregate_issues tests in test_issues.py with org argument Documentation Updates: - Expand tools table from 8 to 36 tools (organized by category) - Update directory structure to show all 6 tool files - Remove unused GITEA_OWNER from configuration docs - Add automatic repository detection documentation - Add project directory detection strategies - Update test count from 42 to 64 - Create CHANGELOG.md with full version history All 64 tests now pass. No production code changes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
271 lines
8.9 KiB
Python
271 lines
8.9 KiB
Python
"""
|
|
Unit tests for Gitea API client.
|
|
"""
|
|
import pytest
|
|
from unittest.mock import Mock, patch, MagicMock
|
|
from mcp_server.gitea_client import GiteaClient
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_config():
|
|
"""Fixture providing mocked configuration"""
|
|
with patch('mcp_server.gitea_client.GiteaConfig') as mock_cfg:
|
|
mock_instance = mock_cfg.return_value
|
|
mock_instance.load.return_value = {
|
|
'api_url': 'https://test.com/api/v1',
|
|
'api_token': 'test_token',
|
|
'repo': 'test_owner/test_repo', # Combined owner/repo format
|
|
'mode': 'project'
|
|
}
|
|
yield mock_cfg
|
|
|
|
|
|
@pytest.fixture
|
|
def gitea_client(mock_config):
|
|
"""Fixture providing GiteaClient instance with mocked config"""
|
|
return GiteaClient()
|
|
|
|
|
|
def test_client_initialization(gitea_client):
|
|
"""Test client initializes with correct configuration"""
|
|
assert gitea_client.base_url == 'https://test.com/api/v1'
|
|
assert gitea_client.token == 'test_token'
|
|
assert gitea_client.repo == 'test_owner/test_repo' # Combined format
|
|
assert gitea_client.mode == 'project'
|
|
assert 'Authorization' in gitea_client.session.headers
|
|
assert gitea_client.session.headers['Authorization'] == 'token test_token'
|
|
|
|
|
|
def test_list_issues(gitea_client):
|
|
"""Test listing issues"""
|
|
mock_response = Mock()
|
|
mock_response.json.return_value = [
|
|
{'number': 1, 'title': 'Test Issue 1'},
|
|
{'number': 2, 'title': 'Test Issue 2'}
|
|
]
|
|
mock_response.raise_for_status = Mock()
|
|
|
|
with patch.object(gitea_client.session, 'get', return_value=mock_response):
|
|
issues = gitea_client.list_issues(state='open')
|
|
|
|
assert len(issues) == 2
|
|
assert issues[0]['title'] == 'Test Issue 1'
|
|
gitea_client.session.get.assert_called_once()
|
|
|
|
|
|
def test_list_issues_with_labels(gitea_client):
|
|
"""Test listing issues with label filter"""
|
|
mock_response = Mock()
|
|
mock_response.json.return_value = [{'number': 1, 'title': 'Bug Issue'}]
|
|
mock_response.raise_for_status = Mock()
|
|
|
|
with patch.object(gitea_client.session, 'get', return_value=mock_response):
|
|
issues = gitea_client.list_issues(state='open', labels=['Type/Bug'])
|
|
|
|
gitea_client.session.get.assert_called_once()
|
|
call_args = gitea_client.session.get.call_args
|
|
assert call_args[1]['params']['labels'] == 'Type/Bug'
|
|
|
|
|
|
def test_get_issue(gitea_client):
|
|
"""Test getting specific issue"""
|
|
mock_response = Mock()
|
|
mock_response.json.return_value = {'number': 1, 'title': 'Test Issue'}
|
|
mock_response.raise_for_status = Mock()
|
|
|
|
with patch.object(gitea_client.session, 'get', return_value=mock_response):
|
|
issue = gitea_client.get_issue(1)
|
|
|
|
assert issue['number'] == 1
|
|
assert issue['title'] == 'Test Issue'
|
|
|
|
|
|
def test_create_issue(gitea_client):
|
|
"""Test creating new issue"""
|
|
mock_response = Mock()
|
|
mock_response.json.return_value = {
|
|
'number': 1,
|
|
'title': 'New Issue',
|
|
'body': 'Issue body'
|
|
}
|
|
mock_response.raise_for_status = Mock()
|
|
|
|
# Mock is_org_repo to avoid network call during label resolution
|
|
with patch.object(gitea_client, 'is_org_repo', return_value=True):
|
|
# Mock get_org_labels and get_labels for label resolution
|
|
with patch.object(gitea_client, 'get_org_labels', return_value=[{'name': 'Type/Bug', 'id': 1}]):
|
|
with patch.object(gitea_client, 'get_labels', return_value=[]):
|
|
with patch.object(gitea_client.session, 'post', return_value=mock_response):
|
|
issue = gitea_client.create_issue(
|
|
title='New Issue',
|
|
body='Issue body',
|
|
labels=['Type/Bug']
|
|
)
|
|
|
|
assert issue['title'] == 'New Issue'
|
|
gitea_client.session.post.assert_called_once()
|
|
|
|
|
|
def test_update_issue(gitea_client):
|
|
"""Test updating existing issue"""
|
|
mock_response = Mock()
|
|
mock_response.json.return_value = {
|
|
'number': 1,
|
|
'title': 'Updated Issue'
|
|
}
|
|
mock_response.raise_for_status = Mock()
|
|
|
|
with patch.object(gitea_client.session, 'patch', return_value=mock_response):
|
|
issue = gitea_client.update_issue(
|
|
issue_number=1,
|
|
title='Updated Issue'
|
|
)
|
|
|
|
assert issue['title'] == 'Updated Issue'
|
|
gitea_client.session.patch.assert_called_once()
|
|
|
|
|
|
def test_add_comment(gitea_client):
|
|
"""Test adding comment to issue"""
|
|
mock_response = Mock()
|
|
mock_response.json.return_value = {'body': 'Test comment'}
|
|
mock_response.raise_for_status = Mock()
|
|
|
|
with patch.object(gitea_client.session, 'post', return_value=mock_response):
|
|
comment = gitea_client.add_comment(1, 'Test comment')
|
|
|
|
assert comment['body'] == 'Test comment'
|
|
gitea_client.session.post.assert_called_once()
|
|
|
|
|
|
def test_get_labels(gitea_client):
|
|
"""Test getting repository labels"""
|
|
mock_response = Mock()
|
|
mock_response.json.return_value = [
|
|
{'name': 'Type/Bug'},
|
|
{'name': 'Priority/High'}
|
|
]
|
|
mock_response.raise_for_status = Mock()
|
|
|
|
with patch.object(gitea_client.session, 'get', return_value=mock_response):
|
|
labels = gitea_client.get_labels()
|
|
|
|
assert len(labels) == 2
|
|
assert labels[0]['name'] == 'Type/Bug'
|
|
|
|
|
|
def test_get_org_labels(gitea_client):
|
|
"""Test getting organization labels"""
|
|
mock_response = Mock()
|
|
mock_response.json.return_value = [
|
|
{'name': 'Type/Bug'},
|
|
{'name': 'Type/Feature'}
|
|
]
|
|
mock_response.raise_for_status = Mock()
|
|
|
|
with patch.object(gitea_client.session, 'get', return_value=mock_response):
|
|
labels = gitea_client.get_org_labels(org='test_owner')
|
|
|
|
assert len(labels) == 2
|
|
|
|
|
|
def test_list_repos(gitea_client):
|
|
"""Test listing organization repositories (PMO mode)"""
|
|
mock_response = Mock()
|
|
mock_response.json.return_value = [
|
|
{'name': 'repo1'},
|
|
{'name': 'repo2'}
|
|
]
|
|
mock_response.raise_for_status = Mock()
|
|
|
|
with patch.object(gitea_client.session, 'get', return_value=mock_response):
|
|
repos = gitea_client.list_repos(org='test_owner')
|
|
|
|
assert len(repos) == 2
|
|
assert repos[0]['name'] == 'repo1'
|
|
|
|
|
|
def test_aggregate_issues(gitea_client):
|
|
"""Test aggregating issues across repositories (PMO mode)"""
|
|
# Mock list_repos
|
|
gitea_client.list_repos = Mock(return_value=[
|
|
{'name': 'repo1'},
|
|
{'name': 'repo2'}
|
|
])
|
|
|
|
# Mock list_issues
|
|
gitea_client.list_issues = Mock(side_effect=[
|
|
[{'number': 1, 'title': 'Issue 1'}], # repo1
|
|
[{'number': 2, 'title': 'Issue 2'}] # repo2
|
|
])
|
|
|
|
aggregated = gitea_client.aggregate_issues(org='test_owner', state='open')
|
|
|
|
assert 'repo1' in aggregated
|
|
assert 'repo2' in aggregated
|
|
assert len(aggregated['repo1']) == 1
|
|
assert len(aggregated['repo2']) == 1
|
|
|
|
|
|
def test_no_repo_specified_error(gitea_client):
|
|
"""Test error when repository not specified or invalid format"""
|
|
# Create client without repo
|
|
with patch('mcp_server.gitea_client.GiteaConfig') as mock_cfg:
|
|
mock_instance = mock_cfg.return_value
|
|
mock_instance.load.return_value = {
|
|
'api_url': 'https://test.com/api/v1',
|
|
'api_token': 'test_token',
|
|
'repo': None, # No repo
|
|
'mode': 'company'
|
|
}
|
|
client = GiteaClient()
|
|
|
|
with pytest.raises(ValueError) as exc_info:
|
|
client.list_issues()
|
|
|
|
assert "Use 'owner/repo' format" in str(exc_info.value)
|
|
|
|
|
|
# ========================================
|
|
# ORGANIZATION DETECTION TESTS
|
|
# ========================================
|
|
|
|
def test_is_organization_true(gitea_client):
|
|
"""Test _is_organization returns True for valid organization"""
|
|
mock_response = Mock()
|
|
mock_response.status_code = 200
|
|
|
|
with patch.object(gitea_client.session, 'get', return_value=mock_response):
|
|
result = gitea_client._is_organization('personal-projects')
|
|
|
|
assert result is True
|
|
gitea_client.session.get.assert_called_once_with(
|
|
'https://test.com/api/v1/orgs/personal-projects'
|
|
)
|
|
|
|
|
|
def test_is_organization_false(gitea_client):
|
|
"""Test _is_organization returns False for user account"""
|
|
mock_response = Mock()
|
|
mock_response.status_code = 404
|
|
|
|
with patch.object(gitea_client.session, 'get', return_value=mock_response):
|
|
result = gitea_client._is_organization('lmiranda')
|
|
|
|
assert result is False
|
|
|
|
|
|
def test_is_org_repo_uses_orgs_endpoint(gitea_client):
|
|
"""Test is_org_repo uses /orgs endpoint instead of owner.type"""
|
|
mock_response = Mock()
|
|
mock_response.status_code = 200
|
|
|
|
with patch.object(gitea_client.session, 'get', return_value=mock_response):
|
|
result = gitea_client.is_org_repo('personal-projects/repo')
|
|
|
|
assert result is True
|
|
# Should call /orgs/personal-projects, not /repos/.../
|
|
gitea_client.session.get.assert_called_once_with(
|
|
'https://test.com/api/v1/orgs/personal-projects'
|
|
)
|