From 2e9a3d1271a84d9382d751829d28f18c34ce2b98 Mon Sep 17 00:00:00 2001 From: Leo Miranda Date: Wed, 28 Jan 2026 15:11:01 +0000 Subject: [PATCH] Update "Change-V5.2.0%3A-Plugin-Enhancements-Proposal.-" --- ...5.2.0%3A-Plugin-Enhancements-Proposal.-.md | 29 ++++++++++++------- 1 file changed, 19 insertions(+), 10 deletions(-) rename Change-V5.2.0%3A-Plugin-Enhancements-Proposal.md => Change-V5.2.0%3A-Plugin-Enhancements-Proposal.-.md (80%) diff --git a/Change-V5.2.0%3A-Plugin-Enhancements-Proposal.md b/Change-V5.2.0%3A-Plugin-Enhancements-Proposal.-.md similarity index 80% rename from Change-V5.2.0%3A-Plugin-Enhancements-Proposal.md rename to Change-V5.2.0%3A-Plugin-Enhancements-Proposal.-.md index b795212..268bd64 100644 --- a/Change-V5.2.0%3A-Plugin-Enhancements-Proposal.md +++ b/Change-V5.2.0%3A-Plugin-Enhancements-Proposal.-.md @@ -12,33 +12,42 @@ This proposal covers 26 enhancement items across 10 plugins, organized into 3 im | Sprint | Focus | Items | Status | |--------|-------|-------|--------| -| Sprint 3 | Hooks (enforcement, validation, detection) | 6 | Planning | +| Sprint 3 | Hooks (enforcement, validation, detection) | 6 | **Implemented** | | Sprint 4 | Commands (new user-facing features) | 16 | Backlog | | Sprint 5 | Documentation (guides, best practices) | 4 | Backlog | ## Implementations -- [Sprint 3: Hooks](Change-V5.2.0%3A-Plugin-Enhancements-Proposal-%28Sprint-3-Hooks%29) - Current +- [Sprint 3: Hooks](Change-V5.2.0%3A-Plugin-Enhancements-Proposal-%28Sprint-3-Hooks%29) - **Completed 2026-01-28** --- -## Sprint 3: Hooks (6 items) +## Sprint 3: Hooks (6 items) - COMPLETED Foundational enforcement and detection hooks that other features may depend on. +**Completed:** 2026-01-28 +**Issues:** #225, #226, #227, #228, #229, #230 +**Milestone:** Sprint 3 - Hooks + ### git-flow (2 items) -1. **Commit enforcement hook** - Validate conventional commit format on all commits (not just `/commit` command). Hook type: `PreToolUse` on Bash (git commit detection) -2. **Branch name validation hook** - Validate branch naming on creation (format: `type/description`, lowercase, max 50 chars). Hook type: `PreToolUse` on Bash (git checkout -b detection) +1. **Commit enforcement hook** - Validate conventional commit format on all commits (not just `/commit` command). Hook type: `PreToolUse` on Bash (git commit detection) - **DONE** +2. **Branch name validation hook** - Validate branch naming on creation (format: `type/description`, lowercase, max 50 chars). Hook type: `PreToolUse` on Bash (git checkout -b detection) - **DONE** ### clarity-assist (1 item) -3. **Auto-suggest hook** - `UserPromptSubmit` hook with vagueness detection, suggests `/clarity-assist` when needed +3. **Auto-suggest hook** - `UserPromptSubmit` hook with vagueness detection, suggests `/clarity-assist` when needed - **DONE** ### data-platform (1 item) -4. **Schema diff detection** - Hook to warn on breaking schema changes. Hook type: `PostToolUse` on file edits to schema files +4. **Schema diff detection** - Hook to warn on breaking schema changes. Hook type: `PostToolUse` on file edits to schema files - **DONE** ### contract-validator (2 items) -5. **SessionStart auto-validate hook** - Smart mode (only runs when plugin files changed since last check) -6. **Breaking change detection** - Warn when interface changes break consumers. Works with auto-validate hook. +5. **SessionStart auto-validate hook** - Smart mode (only runs when plugin files changed since last check) - **DONE** +6. **Breaking change detection** - Warn when interface changes break consumers. Works with auto-validate hook. - **DONE** + +### Lessons Learned +- [Background Agent Permissions Must Be Pre-Granted](lessons/sprints/sprint-3---background-agent-permissions-must-be-pre-granted) +- [Agent Runaway Detection and Timeout Handling](lessons/sprints/sprint-3---agent-runaway-detection-and-timeout-handling) +- [MCP Server Branch Detection Bug](lessons/sprints/sprint-3---mcp-server-branch-detection-bug-runs-from-installed-dir) --- @@ -130,4 +139,4 @@ Reference: [Lesson - Plugin Hooks Must Be in Separate File](lessons%2Fpatterns%2 ### Hook Types - `command` - Execute shell script (recommended for complex logic) -- `prompt` - Inject prompt text (lightweight, no execution) +- `prompt` - Inject prompt text (lightweight, no execution) \ No newline at end of file