personal-projects/personal-portfolio
Template
1
1
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

fix: Use os.environ[] instead of .get() for DATABASE_URL
Some checks failed
CI / lint-and-test (push) Has been cancelled
Details

Browse Source 
Fixes Pylance type error - create_engine() expects str, not str | None.
Using direct access raises KeyError if not set, which is correct behavior.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Leo Miranda
2026-01-18 23:03:23 -05:00
parent 546ee1cc92
commit 92763a17c4
15 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
notebooks/amenities/amenity_index_choropleth.ipynb
View File

@@ -38,7 +38,7 @@
"# Load .env from project root\n",
"load_dotenv('../../.env')\n",
"\n",
"engine = create_engine(os.environ.get('DATABASE_URL'))\n",
"engine = create_engine(os.environ['DATABASE_URL'])\n",
"\n",
"query = \"\"\"\n",
"SELECT\n",

2
notebooks/amenities/amenity_radar.ipynb
View File

@@ -29,7 +29,7 @@
"execution_count": null,
"metadata": {},
"outputs": [],
"source": "import pandas as pd\nfrom sqlalchemy import create_engine\nfrom dotenv import load_dotenv\nimport os\n\n# Load .env from project root\nload_dotenv('../../.env')\n\nengine = create_engine(os.environ.get('DATABASE_URL'))\n\nquery = \"\"\"\nSELECT\n neighbourhood_name,\n parks_index,\n schools_index,\n transit_index,\n amenity_index,\n amenity_tier\nFROM public_marts.mart_neighbourhood_amenities\nWHERE year = (SELECT MAX(year) FROM public_marts.mart_neighbourhood_amenities)\nORDER BY amenity_index DESC\n\"\"\"\n\ndf = pd.read_sql(query, engine)\nprint(f\"Loaded {len(df)} neighbourhoods\")"
"source": "import pandas as pd\nfrom sqlalchemy import create_engine\nfrom dotenv import load_dotenv\nimport os\n\n# Load .env from project root\nload_dotenv('../../.env')\n\nengine = create_engine(os.environ['DATABASE_URL'])\n\nquery = \"\"\"\nSELECT\n neighbourhood_name,\n parks_index,\n schools_index,\n transit_index,\n amenity_index,\n amenity_tier\nFROM public_marts.mart_neighbourhood_amenities\nWHERE year = (SELECT MAX(year) FROM public_marts.mart_neighbourhood_amenities)\nORDER BY amenity_index DESC\n\"\"\"\n\ndf = pd.read_sql(query, engine)\nprint(f\"Loaded {len(df)} neighbourhoods\")"
},
{
"cell_type": "markdown",

2
notebooks/amenities/transit_accessibility_bar.ipynb
View File

@@ -38,7 +38,7 @@
"# Load .env from project root\n",
"load_dotenv('../../.env')\n",
"\n",
"engine = create_engine(os.environ.get('DATABASE_URL'))\n",
"engine = create_engine(os.environ['DATABASE_URL'])\n",
"\n",
"query = \"\"\"\n",
"SELECT\n",