personal-projects/personal-portfolio
Template
1
1
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Remove TRREB references from Python modules and SQLAlchemy models #49

New Issue
Closed
opened 2026-01-16 14:54:09 +00:00 by lmiranda · 0 comments
lmiranda commented 2026-01-16 14:54:09 +00:00
Owner
Copy Link

Description

Update Python module init files and SQLAlchemy model files to remove all TRREB imports and class definitions.

Branch: feature/9-cleanup

Reference: docs/changes/Change-Toronto-Analysis-Reviewed.md - Phase 1

Files to MODIFY

File Action
portfolio_app/toronto/schemas/__init__.py Remove TRREB schema imports
portfolio_app/toronto/parsers/__init__.py Remove TRREB parser imports
portfolio_app/toronto/loaders/__init__.py Remove TRREB loader imports
portfolio_app/toronto/models/facts.py Remove FactPurchases model class
portfolio_app/toronto/models/dimensions.py Remove DimTRREBDistrict model class
portfolio_app/toronto/demo_data.py Remove TRREB demo data generation

Acceptance Criteria

  • All __init__.py files have no TRREB imports
  • FactPurchases class removed from models/facts.py
  • DimTRREBDistrict class removed from models/dimensions.py
  • demo_data.py has no TRREB data generation code
  • python -c "from portfolio_app.toronto.models import facts, dimensions" succeeds
  • Application starts without import errors (make run)
  • All remaining imports and __all__ exports are consistent

Technical Notes

  • Keep CMHC-related models and imports intact
  • Keep base classes (Base, FactBase, etc.)
  • Ensure __all__ lists in __init__.py files are updated
  • SQLAlchemy models may have relationships that need careful removal

Sprint

Sprint 9 - Phase 1 (Cleanup)

Labels: Type/Refactor, Priority/High, Efforts/M, Component/Backend, Component/Database, Tech/Python

## Description Update Python module init files and SQLAlchemy model files to remove all TRREB imports and class definitions. **Branch:** `feature/9-cleanup` **Reference:** `docs/changes/Change-Toronto-Analysis-Reviewed.md` - Phase 1 ## Files to MODIFY | File | Action | |------|--------| | `portfolio_app/toronto/schemas/__init__.py` | Remove TRREB schema imports | | `portfolio_app/toronto/parsers/__init__.py` | Remove TRREB parser imports | | `portfolio_app/toronto/loaders/__init__.py` | Remove TRREB loader imports | | `portfolio_app/toronto/models/facts.py` | Remove `FactPurchases` model class | | `portfolio_app/toronto/models/dimensions.py` | Remove `DimTRREBDistrict` model class | | `portfolio_app/toronto/demo_data.py` | Remove TRREB demo data generation | ## Acceptance Criteria - [ ] All `__init__.py` files have no TRREB imports - [ ] `FactPurchases` class removed from `models/facts.py` - [ ] `DimTRREBDistrict` class removed from `models/dimensions.py` - [ ] `demo_data.py` has no TRREB data generation code - [ ] `python -c "from portfolio_app.toronto.models import facts, dimensions"` succeeds - [ ] Application starts without import errors (`make run`) - [ ] All remaining imports and `__all__` exports are consistent ## Technical Notes - Keep CMHC-related models and imports intact - Keep base classes (`Base`, `FactBase`, etc.) - Ensure `__all__` lists in `__init__.py` files are updated - SQLAlchemy models may have relationships that need careful removal ## Sprint Sprint 9 - Phase 1 (Cleanup) **Labels:** Type/Refactor, Priority/High, Efforts/M, Component/Backend, Component/Database, Tech/Python
lmiranda added this to the Launch: Host, Bio and Toronto House Market Analysis project 2026-01-16 14:55:49 +00:00
lmiranda self-assigned this 2026-01-16 14:55:54 +00:00
lmiranda moved this to To Do in Launch: Host, Bio and Toronto House Market Analysis on 2026-01-16 14:56:01 +00:00
lmiranda moved this to Done in Launch: Host, Bio and Toronto House Market Analysis on 2026-01-16 15:33:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complexity/Complex
High uncertainty or many dependencies
 Complexity/Medium
Some unknowns or dependencies
 Complexity/Simple
Straightforward, well-understood
 Effort/L
3-5 days
 Effort/M
1-2 days
 Effort/S
2-4 hours
 Effort/XL
> 1 week
 Effort/XS
< 2 hours
 Priority/Critical
Immediate attention required
 Priority/High
Important, needs attention soon
 Priority/Low
Nice to have, can wait
 Priority/Medium
Normal priority
 Type/Bug
Something isn't working
 Type/Chore
Maintenance tasks
 Type/Documentation
Documentation improvements
 Type/Feature
New feature or request
 Type/Refactor
Code refactoring without changing behavior
 Type/Test
Testing related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Launch: Host, Bio and Toronto House Market Analysis
Assignees
Clear assignees
lmiranda
No Assignees lmiranda
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: personal-projects/personal-portfolio#49
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?