Phase 2, Task 2.2.1: Users API Implementation (Sync)
This commit adds comprehensive user management capabilities to the
Wiki.js Python SDK with full CRUD operations.
User Data Models (wikijs/models/user.py):
-----------------------------------------
1. **User** - Complete user data model
- Profile information (name, email, location, job title)
- Authentication details (provider, verified, active status)
- Group memberships with UserGroup nested model
- Timestamps (created, updated, last login)
- Email validation with pydantic EmailStr
- Name validation (2-255 characters)
2. **UserCreate** - User creation model
- Required: email, name, password
- Optional: groups, profile fields, provider settings
- Validation: email format, password strength (min 6 chars)
- Welcome email configuration
- Password change enforcement
3. **UserUpdate** - User update model
- All fields optional for partial updates
- Email, name, password updates
- Profile field updates
- Group membership changes
- Status flags (active, verified)
4. **UserGroup** - Group membership model
- Group ID and name
- Used in User model for group associations
Users Endpoint (wikijs/endpoints/users.py):
-------------------------------------------
Complete CRUD Operations:
1. **list()** - List users with filtering
- Pagination (limit, offset)
- Search by name/email
- Ordering (name, email, createdAt, lastLoginAt)
- Client-side pagination fallback
2. **get(user_id)** - Get user by ID
- Fetch single user with full details
- Include group memberships
- Comprehensive error handling
3. **create(user_data)** - Create new user
- Accept UserCreate object or dict
- Full validation before API call
- Returns created User object
- Handles creation failures gracefully
4. **update(user_id, user_data)** - Update existing user
- Partial updates supported
- Only sends changed fields
- Returns updated User object
- Validates all updates
5. **delete(user_id)** - Delete user
- Permanent deletion
- Returns boolean success
- Clear error messages
6. **search(query)** - Search users
- Search by name or email
- Optional result limiting
- Uses list() with search filter
Helper Methods:
- _normalize_user_data() - API response normalization
- Handles field name mapping (camelCase → snake_case)
- Group data structure conversion
Integration:
------------
- Added UsersEndpoint to WikiJSClient
- Updated endpoints module exports
- Added user models to main package exports
- Installed email-validator dependency for EmailStr
GraphQL Queries:
----------------
- users.list - List/search users
- users.single - Get user by ID
- users.create - Create new user
- users.update - Update existing user
- users.delete - Delete user
All queries include proper error handling and response validation.
Code Quality:
-------------
✅ Compiles without errors
✅ Type hints on all methods
✅ Comprehensive docstrings
✅ Input validation
✅ Proper exception handling
✅ Follows existing code patterns
Next Steps:
-----------
- Implement AsyncUsersEndpoint (async version)
- Write comprehensive tests
- Add usage documentation
- Create examples
Phase 2, Task 2.2.1 Progress: ~50% Complete
Users API (sync): ✅ COMPLETE
Users API (async): ⏳ IN PROGRESS
This establishes the foundation for complete user management
in the Wiki.js Python SDK.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
**Critical Fixes:**
1. **Fixed Error Hierarchy** (wikijs/exceptions.py)
- ConnectionError and TimeoutError now properly inherit from APIError
- Ensures consistent exception handling across the SDK
- Added proper __init__ methods with status_code=None
2. **Fixed test_connection Method** (wikijs/client.py)
- Changed from basic HTTP GET to proper GraphQL query validation
- Now uses query { site { title } } to validate API connectivity
- Provides better error messages for authentication failures
- Validates both connectivity AND API access
3. **Implemented JWT Token Refresh** (wikijs/auth/jwt.py)
- Added base_url parameter to JWTAuth class
- Implemented complete refresh() method with HTTP request to /api/auth/refresh
- Handles token, refresh token, and expiration updates
- Proper error handling for network failures and auth errors
**Bonus Fixes:**
- Dynamic user agent version (uses __version__ from version.py instead of hardcoded)
- Updated all JWT tests to include required base_url parameter
- Updated test mocks to match new GraphQL-based test_connection
**Test Results:**
- All 231 tests passing ✅
- Test coverage: 91.64% (target: 85%) ✅
- No test failures or errors
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Removed trailing whitespace from blank lines (W293)
- All flake8 checks now pass
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Fixed black formatting in exceptions.py
- Restored parse_wiki_response to original behavior (return input unchanged for non-dict)
- Enhanced validate_url to properly reject URLs with spaces
- Fixed 3 previously failing utility tests
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Removed trailing whitespace from blank line in client.py:66
- All flake8 checks now pass
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Updated mypy configuration to use Python 3.9+
- Added missing type annotations to all function parameters
- Fixed type compatibility issues in variable assignments
- Resolved unreachable code and return type warnings
- All mypy checks now pass successfully
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Updated GitHub Actions workflow to use correct flake8 configuration
- Fixed line length issues by using 88 characters as configured
- Removed unused imports and trailing whitespace
- Fixed f-string placeholders and unused variables
- All linting checks now pass with project configuration
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
✅ Implemented comprehensive authentication system:
- Abstract AuthHandler base class with pluggable architecture
- APIKeyAuth for API key authentication (string auto-conversion)
- JWTAuth for JWT token authentication with expiration handling
- NoAuth for testing and public instances
- Full integration with WikiJSClient for automatic header management
🔧 Fixed packaging issues:
- Updated pyproject.toml with required project metadata fields
- Fixed utility function exports in utils/__init__.py
- Package now installs correctly in virtual environments
🧪 Validated with comprehensive tests:
- All authentication methods working correctly
- Proper error handling for invalid credentials
- Type validation and security features
📊 Progress: Phase 1 MVP Development now 60% complete
🎯 Next: Task 1.4 - Pages API implementation
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
✅ Task 1.1 - Project Foundation Setup:
- Repository structure with Python packaging (setup.py, pyproject.toml)
- Development dependencies and requirements
- Contributing guidelines and MIT license
- GitHub workflows for CI/CD (test.yml, release.yml)
- Issue and PR templates for community contributions
- Comprehensive project documentation
✅ Task 1.2 - Core Client Structure:
- wikijs package with proper module organization
- Core client class foundation in client.py
- Exception hierarchy for error handling
- Base model classes and page models
- Type checking support (py.typed)
- Utility modules and helper functions
📊 Progress: Phase 1 MVP Development now 40% complete
🎯 Next: Task 1.3 - Authentication System implementation
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
