feat(plugins): implement Sprint 4 commands (#241-#258)

Sprint 4 - Plugin Commands implementation adding 18 new user-facing commands across 8 plugins as part of V5.2.0 Plugin Enhancements. **projman:** - #241: /sprint-diagram - Mermaid visualization of sprint issues **pr-review:** - #242: Confidence threshold config (PR_REVIEW_CONFIDENCE_THRESHOLD) - #243: /pr-diff - Formatted diff with inline review comments **data-platform:** - #244: /data-quality - DataFrame quality checks (nulls, duplicates, outliers) - #245: /lineage-viz - dbt lineage as Mermaid diagrams - #246: /dbt-test - Formatted dbt test runner **viz-platform:** - #247: /chart-export - Export charts to PNG/SVG/PDF via kaleido - #248: /accessibility-check - Color blind validation (WCAG contrast) - #249: /breakpoints - Responsive layout configuration **contract-validator:** - #250: /dependency-graph - Plugin dependency visualization **doc-guardian:** - #251: /changelog-gen - Generate changelog from conventional commits - #252: /doc-coverage - Documentation coverage metrics - #253: /stale-docs - Flag outdated documentation **claude-config-maintainer:** - #254: /config-diff - Track CLAUDE.md changes over time - #255: /config-lint - 31 lint rules for CLAUDE.md best practices **cmdb-assistant:** - #256: /cmdb-topology - Infrastructure topology diagrams - #257: /change-audit - NetBox audit trail queries - #258: /ip-conflicts - Detect IP conflicts and overlaps Closes #241, #242, #243, #244, #245, #246, #247, #248, #249, #250, #251, #252, #253, #254, #255, #256, #257, #258 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-28 12:02:26 -05:00
parent 8a957b1b69
commit 9698e8724d
36 changed files with 4295 additions and 22 deletions
--- a/plugins/data-platform/README.md
+++ b/plugins/data-platform/README.md
@@ -49,10 +49,13 @@ DBT_PROFILES_DIR=~/.dbt
 | `/initial-setup` | Interactive setup wizard for PostgreSQL and dbt configuration |
 | `/ingest` | Load data from files or database |
 | `/profile` | Generate data profile and statistics |
+| `/data-quality` | Data quality assessment with pass/warn/fail scoring |
 | `/schema` | Show database/DataFrame schema |
 | `/explain` | Explain dbt model lineage |
-| `/lineage` | Visualize data dependencies |
+| `/lineage` | Visualize data dependencies (ASCII) |
+| `/lineage-viz` | Generate Mermaid flowchart for dbt lineage |
 | `/run` | Execute dbt models |
+| `/dbt-test` | Run dbt tests with formatted results |

 ## Agents

--- a/plugins/data-platform/commands/data-quality.md
+++ b/plugins/data-platform/commands/data-quality.md
@@ -0,0 +1,103 @@
+# /data-quality - Data Quality Assessment
+
+Comprehensive data quality check for DataFrames with pass/warn/fail scoring.
+
+## Usage
+
+```
+/data-quality <data_ref> [--strict]
+```
+
+## Workflow
+
+1. **Get data reference**:
+   - If no data_ref provided, use `list_data` to show available options
+   - Validate the data_ref exists
+
+2. **Null analysis**:
+   - Calculate null percentage per column
+   - **PASS**: < 5% nulls
+   - **WARN**: 5-20% nulls
+   - **FAIL**: > 20% nulls
+
+3. **Duplicate detection**:
+   - Check for fully duplicated rows
+   - **PASS**: 0% duplicates
+   - **WARN**: < 1% duplicates
+   - **FAIL**: >= 1% duplicates
+
+4. **Type consistency**:
+   - Identify mixed-type columns (object columns with mixed content)
+   - Flag columns that could be numeric but contain strings
+   - **PASS**: All columns have consistent types
+   - **FAIL**: Mixed types detected
+
+5. **Outlier detection** (numeric columns):
+   - Use IQR method (values beyond 1.5 * IQR)
+   - Report percentage of outliers per column
+   - **PASS**: < 1% outliers
+   - **WARN**: 1-5% outliers
+   - **FAIL**: > 5% outliers
+
+6. **Generate quality report**:
+   - Overall quality score (0-100)
+   - Per-column breakdown
+   - Recommendations for remediation
+
+## Report Format
+
+```
+=== Data Quality Report ===
+Dataset: sales_data
+Rows: 10,000 | Columns: 15
+Overall Score: 82/100 [PASS]
+
+--- Column Analysis ---
+| Column       | Nulls | Dups | Type     | Outliers | Status |
+|--------------|-------|------|----------|----------|--------|
+| customer_id  | 0.0%  | -    | int64    | 0.2%     | PASS   |
+| email        | 2.3%  | -    | object   | -        | PASS   |
+| amount       | 15.2% | -    | float64  | 3.1%     | WARN   |
+| created_at   | 0.0%  | -    | datetime | -        | PASS   |
+
+--- Issues Found ---
+[WARN] Column 'amount': 15.2% null values (threshold: 5%)
+[WARN] Column 'amount': 3.1% outliers detected
+[FAIL] 1.2% duplicate rows detected (12 rows)
+
+--- Recommendations ---
+1. Investigate null values in 'amount' column
+2. Review outliers in 'amount' - may be data entry errors
+3. Remove or deduplicate 12 duplicate rows
+```
+
+## Options
+
+| Flag | Description |
+|------|-------------|
+| `--strict` | Use stricter thresholds (WARN at 1% nulls, FAIL at 5%) |
+
+## Examples
+
+```
+/data-quality sales_data
+/data-quality df_customers --strict
+```
+
+## Scoring
+
+| Component | Weight | Scoring |
+|-----------|--------|---------|
+| Nulls | 30% | 100 - (avg_null_pct * 2) |
+| Duplicates | 20% | 100 - (dup_pct * 50) |
+| Type consistency | 25% | 100 if clean, 0 if mixed |
+| Outliers | 25% | 100 - (avg_outlier_pct * 10) |
+
+Final score: Weighted average, capped at 0-100
+
+## Available Tools
+
+Use these MCP tools:
+- `describe` - Get statistical summary (for outlier detection)
+- `head` - Preview data
+- `list_data` - List available DataFrames
--- a/plugins/data-platform/commands/dbt-test.md
+++ b/plugins/data-platform/commands/dbt-test.md
@@ -0,0 +1,119 @@
+# /dbt-test - Run dbt Tests
+
+Execute dbt tests with formatted pass/fail results.
+
+## Usage
+
+```
+/dbt-test [selection] [--warn-only]
+```
+
+## Workflow
+
+1. **Pre-validation** (MANDATORY):
+   - Use `dbt_parse` to validate project first
+   - If validation fails, show errors and STOP
+
+2. **Execute tests**:
+   - Use `dbt_test` with provided selection
+   - Capture all test results
+
+3. **Format results**:
+   - Group by test type (schema vs. data)
+   - Show pass/fail status with counts
+   - Display failure details
+
+## Report Format
+
+```
+=== dbt Test Results ===
+Project: my_project
+Selection: tag:critical
+
+--- Summary ---
+Total: 24 tests
+PASS:  22 (92%)
+FAIL:  1  (4%)
+WARN:  1  (4%)
+SKIP:  0  (0%)
+
+--- Schema Tests (18) ---
+[PASS] unique_dim_customers_customer_id
+[PASS] not_null_dim_customers_customer_id
+[PASS] not_null_dim_customers_email
+[PASS] accepted_values_dim_customers_status
+[FAIL] relationships_fct_orders_customer_id
+
+--- Data Tests (6) ---
+[PASS] assert_positive_order_amounts
+[PASS] assert_valid_dates
+[WARN] assert_recent_orders (threshold: 7 days)
+
+--- Failure Details ---
+Test: relationships_fct_orders_customer_id
+Type: schema (relationships)
+Model: fct_orders
+Message: 15 records failed referential integrity check
+Query: SELECT * FROM fct_orders WHERE customer_id NOT IN (SELECT customer_id FROM dim_customers)
+
+--- Warning Details ---
+Test: assert_recent_orders
+Type: data
+Message: No orders in last 7 days (expected for dev environment)
+Severity: warn
+```
+
+## Selection Syntax
+
+| Pattern | Meaning |
+|---------|---------|
+| (none) | Run all tests |
+| `model_name` | Tests for specific model |
+| `+model_name` | Tests for model and upstream |
+| `tag:critical` | Tests with tag |
+| `test_type:schema` | Only schema tests |
+| `test_type:data` | Only data tests |
+
+## Options
+
+| Flag | Description |
+|------|-------------|
+| `--warn-only` | Treat failures as warnings (don't fail CI) |
+
+## Examples
+
+```
+/dbt-test                          # Run all tests
+/dbt-test dim_customers            # Tests for specific model
+/dbt-test tag:critical             # Run critical tests only
+/dbt-test +fct_orders              # Test model and its upstream
+```
+
+## Test Types
+
+### Schema Tests
+Built-in tests defined in `schema.yml`:
+- `unique` - No duplicate values
+- `not_null` - No null values
+- `accepted_values` - Value in allowed list
+- `relationships` - Foreign key integrity
+
+### Data Tests
+Custom SQL tests in `tests/` directory:
+- Return rows that fail the assertion
+- Zero rows = pass, any rows = fail
+
+## Exit Codes
+
+| Code | Meaning |
+|------|---------|
+| 0 | All tests passed |
+| 1 | One or more tests failed |
+| 2 | dbt error (parse failure, etc.) |
+
+## Available Tools
+
+Use these MCP tools:
+- `dbt_parse` - Pre-validation (ALWAYS RUN FIRST)
+- `dbt_test` - Execute tests (REQUIRED)
+- `dbt_build` - Alternative: run + test together
--- a/plugins/data-platform/commands/lineage-viz.md
+++ b/plugins/data-platform/commands/lineage-viz.md
@@ -0,0 +1,125 @@
+# /lineage-viz - Mermaid Lineage Visualization
+
+Generate Mermaid flowchart syntax for dbt model lineage.
+
+## Usage
+
+```
+/lineage-viz <model_name> [--direction TB|LR] [--depth N]
+```
+
+## Workflow
+
+1. **Get lineage data**:
+   - Use `dbt_lineage` to fetch model dependencies
+   - Capture upstream sources and downstream consumers
+
+2. **Build Mermaid graph**:
+   - Create nodes for each model/source
+   - Style nodes by materialization type
+   - Add directional arrows for dependencies
+
+3. **Output**:
+   - Render Mermaid flowchart syntax
+   - Include copy-paste ready code block
+
+## Output Format
+
+```mermaid
+flowchart LR
+    subgraph Sources
+        raw_customers[(raw_customers)]
+        raw_orders[(raw_orders)]
+    end
+
+    subgraph Staging
+        stg_customers[stg_customers]
+        stg_orders[stg_orders]
+    end
+
+    subgraph Marts
+        dim_customers{{dim_customers}}
+        fct_orders{{fct_orders}}
+    end
+
+    raw_customers --> stg_customers
+    raw_orders --> stg_orders
+    stg_customers --> dim_customers
+    stg_orders --> fct_orders
+    dim_customers --> fct_orders
+```
+
+## Node Styles
+
+| Materialization | Mermaid Shape | Example |
+|-----------------|---------------|---------|
+| source | Cylinder `[( )]` | `raw_data[(raw_data)]` |
+| view | Rectangle `[ ]` | `stg_model[stg_model]` |
+| table | Double braces `{{ }}` | `dim_model{{dim_model}}` |
+| incremental | Hexagon `{{ }}` | `fct_model{{fct_model}}` |
+| ephemeral | Dashed `[/ /]` | `tmp_model[/tmp_model/]` |
+
+## Options
+
+| Flag | Description |
+|------|-------------|
+| `--direction TB` | Top-to-bottom layout (default: LR = left-to-right) |
+| `--depth N` | Limit lineage depth (default: unlimited) |
+
+## Examples
+
+```
+/lineage-viz dim_customers
+/lineage-viz fct_orders --direction TB
+/lineage-viz rpt_revenue --depth 2
+```
+
+## Usage Tips
+
+1. **Paste in documentation**: Copy the output directly into README.md or docs
+2. **GitHub/GitLab rendering**: Both platforms render Mermaid natively
+3. **Mermaid Live Editor**: Paste at https://mermaid.live for interactive editing
+
+## Example Output
+
+For `/lineage-viz fct_orders`:
+
+~~~markdown
+```mermaid
+flowchart LR
+    %% Sources
+    raw_customers[(raw_customers)]
+    raw_orders[(raw_orders)]
+    raw_products[(raw_products)]
+
+    %% Staging
+    stg_customers[stg_customers]
+    stg_orders[stg_orders]
+    stg_products[stg_products]
+
+    %% Marts
+    dim_customers{{dim_customers}}
+    dim_products{{dim_products}}
+    fct_orders{{fct_orders}}
+
+    %% Dependencies
+    raw_customers --> stg_customers
+    raw_orders --> stg_orders
+    raw_products --> stg_products
+    stg_customers --> dim_customers
+    stg_products --> dim_products
+    stg_orders --> fct_orders
+    dim_customers --> fct_orders
+    dim_products --> fct_orders
+
+    %% Highlight target model
+    style fct_orders fill:#f96,stroke:#333,stroke-width:2px
+```
+~~~
+
+## Available Tools
+
+Use these MCP tools:
+- `dbt_lineage` - Get model dependencies (REQUIRED)
+- `dbt_ls` - List dbt resources
+- `dbt_docs_generate` - Generate full manifest if needed