personal-projects/leo-claude-mktplace
Template
0
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(scripts): MCP server mapping and CLAUDE.md section markers #395

Merged
lmiranda merged 1 commits from fix/plugin-install-mcp-mapping into development 2026-02-03 00:37:16 +00:00
Conversation 0 Commits 1 Files Changed 10 +297 -94
lmiranda commented 2026-02-03 00:34:47 +00:00
Owner
Copy Link

Summary

Fixes two issues in the plugin installation scripts:

Issue 1: Shared MCP Server Mapping

  • Added mcp_servers field to plugin.json for plugins using shared MCP servers
  • projman and pr-review now correctly install gitea MCP server
  • cmdb-assistant now correctly installs netbox MCP server
  • Scripts read MCP server names from plugin.json instead of assuming plugin name = server name

Issue 2: CLAUDE.md Section Markers

  • Install script now wraps content with HTML comment markers:
    <!-- BEGIN marketplace-plugin: {name} --> and <!-- END marketplace-plugin: {name} -->
  • Uninstall uses markers for precise section removal (no more code block false positives)
  • Backward compatible: falls back to legacy header detection

Bug Fix

  • Changed ((servers_added++)) to ((++servers_added)) to avoid exit code 1 with set -e when incrementing from 0

Files Changed

File Change
plugins/*/plugin.json Added mcp_servers field
scripts/install-plugin.sh Read from mcp_servers, add HTML markers
scripts/uninstall-plugin.sh Read from mcp_servers, use HTML markers
scripts/list-installed.sh Check against mcp_servers field
CHANGELOG.md Document fixes

Test plan

  • Validated marketplace with ./scripts/validate-marketplace.sh
  • Tested projman installs gitea MCP server (not projman)
  • Tested HTML markers are added to CLAUDE.md
  • Tested uninstall removes section using markers
  • Tested list-installed shows correct status

🤖 Generated with Claude Code

## Summary Fixes two issues in the plugin installation scripts: ### Issue 1: Shared MCP Server Mapping - Added `mcp_servers` field to `plugin.json` for plugins using shared MCP servers - `projman` and `pr-review` now correctly install `gitea` MCP server - `cmdb-assistant` now correctly installs `netbox` MCP server - Scripts read MCP server names from `plugin.json` instead of assuming plugin name = server name ### Issue 2: CLAUDE.md Section Markers - Install script now wraps content with HTML comment markers: `<!-- BEGIN marketplace-plugin: {name} -->` and `<!-- END marketplace-plugin: {name} -->` - Uninstall uses markers for precise section removal (no more code block false positives) - Backward compatible: falls back to legacy header detection ### Bug Fix - Changed `((servers_added++))` to `((++servers_added))` to avoid exit code 1 with `set -e` when incrementing from 0 ## Files Changed | File | Change | |------|--------| | `plugins/*/plugin.json` | Added `mcp_servers` field | | `scripts/install-plugin.sh` | Read from `mcp_servers`, add HTML markers | | `scripts/uninstall-plugin.sh` | Read from `mcp_servers`, use HTML markers | | `scripts/list-installed.sh` | Check against `mcp_servers` field | | `CHANGELOG.md` | Document fixes | ## Test plan - [x] Validated marketplace with `./scripts/validate-marketplace.sh` - [x] Tested projman installs gitea MCP server (not projman) - [x] Tested HTML markers are added to CLAUDE.md - [x] Tested uninstall removes section using markers - [x] Tested list-installed shows correct status 🤖 Generated with [Claude Code](https://claude.ai/code)
lmiranda added the Type/Bug label 2026-02-03 00:34:47 +00:00
lmiranda added 1 commit 2026-02-03 00:34:48 +00:00
fix(scripts): MCP server mapping and CLAUDE.md section markers eafcfe5bd1 
Issue 1 - MCP Server Mapping:
- Add mcp_servers field to plugin.json for plugins using shared MCP servers
- projman/pr-review now install gitea MCP server
- cmdb-assistant now installs netbox MCP server
- Scripts read MCP server names from plugin.json

Issue 2 - CLAUDE.md Section Markers:
- Install wraps content with HTML comment markers for precise removal
- Uninstall uses markers first, falls back to legacy header detection
- Fixes code block false positives during uninstall

Bug fix:
- Change ((servers_added++)) to ((++servers_added)) to avoid exit code 1
  with set -e when incrementing from 0

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lmiranda merged commit 5b1dde694c into development 2026-02-03 00:37:16 +00:00
lmiranda deleted branch fix/plugin-install-mcp-mapping 2026-02-03 00:37:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Component/API
API endpoints, contracts, and integration
 Component/Auth
Authentication and authorization
 Component/Backend
Backend service code and business logic
 Component/Database
Database schemas, migrations, queries
 Component/Deploy
Deployment, infrastructure, DevOps
 Component/Docs
Documentation and guides
 Component/Frontend
User interface and client-side code
 Component/Infra
Infrastructure and system configuration
 Component/Testing
Test infrastructure and frameworks
 Tech/Docker
Docker containers and compose
 Tech/FastAPI
FastAPI backend framework
 Tech/JavaScript
JavaScript/Node.js code
 Tech/PostgreSQL
PostgreSQL database
 Tech/Python
Python language and libraries
 Tech/Redis
Redis cache and pub/sub
 Tech/Vue
Vue.js frontend framework
Complexity/Complex
High uncertainty or many dependencies
 Complexity/Medium
Some unknowns or dependencies
 Complexity/Simple
Straightforward, well-understood
 Effort/L
3-5 days
 Effort/M
1-2 days
 Effort/S
2-4 hours
 Effort/XL
> 1 week
 Effort/XS
< 2 hours
 Priority/Critical
Immediate attention required
 Priority/High
Important, needs attention soon
 Priority/Low
Nice to have, can wait
 Priority/Medium
Normal priority
 Type/Bug
Something isn't working
 Type/Chore
Maintenance tasks
 Type/Documentation
Documentation improvements
 Type/Feature
New feature or request
 Type/Refactor
Code refactoring without changing behavior
 Type/Test
Testing related
No Label Type/Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lmiranda
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: personal-projects/leo-claude-mktplace#395
Delete Branch "fix/plugin-install-mcp-mapping"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?