lmiranda
a74a048898
Add validation hooks, best practices skill, and new commands to enforce NetBox data quality standards: Hooks: - SessionStart: Test NetBox connectivity, report data quality issues - PreToolUse: Validate VM/device parameters before create/update New Commands: - /cmdb-audit: Data quality analysis (vms, devices, naming, roles) - /cmdb-register: Register current machine with running applications - /cmdb-sync: Sync machine state with NetBox, detect drift Best Practices Skill: - Dependency order (regions -> sites -> devices -> VMs) - Site/tenant/platform assignment requirements - Naming conventions enforcement - Role consolidation guidance Updated agent with validation requirements, dependency order checks, naming convention warnings, and duplicate prevention. Marketplace: 5.0.0 -> 5.1.0 Plugin: 1.0.0 -> 1.1.0 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
80 lines
2.6 KiB
Bash
Executable File
80 lines
2.6 KiB
Bash
Executable File
#!/bin/bash
|
|
# cmdb-assistant PreToolUse validation hook
|
|
# Validates input parameters for create/update operations
|
|
# NON-BLOCKING: Warns but allows operation to proceed (always exits 0)
|
|
|
|
set -euo pipefail
|
|
|
|
PREFIX="[cmdb-assistant]"
|
|
|
|
# Read tool input from stdin
|
|
INPUT=$(cat)
|
|
|
|
# Extract tool name from the input
|
|
# Format varies, try to find tool_name or name field
|
|
TOOL_NAME=""
|
|
if echo "$INPUT" | grep -q '"tool_name"'; then
|
|
TOOL_NAME=$(echo "$INPUT" | grep -o '"tool_name"[[:space:]]*:[[:space:]]*"[^"]*"' | head -1 | sed 's/.*"\([^"]*\)"$/\1/' || true)
|
|
elif echo "$INPUT" | grep -q '"name"'; then
|
|
TOOL_NAME=$(echo "$INPUT" | grep -o '"name"[[:space:]]*:[[:space:]]*"[^"]*"' | head -1 | sed 's/.*"\([^"]*\)"$/\1/' || true)
|
|
fi
|
|
|
|
# If we can't determine the tool, exit silently
|
|
if [[ -z "$TOOL_NAME" ]]; then
|
|
exit 0
|
|
fi
|
|
|
|
# VM creation/update validation
|
|
if echo "$TOOL_NAME" | grep -qE "virt_create_vm|virt_create_virtual_machine|virt_update_vm|virt_update_virtual_machine"; then
|
|
WARNINGS=()
|
|
|
|
# Check for missing site
|
|
if ! echo "$INPUT" | grep -qE '"site"[[:space:]]*:[[:space:]]*[0-9]'; then
|
|
WARNINGS+=("no site assigned")
|
|
fi
|
|
|
|
# Check for missing tenant
|
|
if ! echo "$INPUT" | grep -qE '"tenant"[[:space:]]*:[[:space:]]*[0-9]'; then
|
|
WARNINGS+=("no tenant assigned")
|
|
fi
|
|
|
|
# Check for missing platform
|
|
if ! echo "$INPUT" | grep -qE '"platform"[[:space:]]*:[[:space:]]*[0-9]'; then
|
|
WARNINGS+=("no platform assigned")
|
|
fi
|
|
|
|
if [[ ${#WARNINGS[@]} -gt 0 ]]; then
|
|
echo "$PREFIX VM best practice: $(IFS=', '; echo "${WARNINGS[*]}") - consider assigning for data quality"
|
|
fi
|
|
fi
|
|
|
|
# Device creation/update validation
|
|
if echo "$TOOL_NAME" | grep -qE "dcim_create_device|dcim_update_device"; then
|
|
WARNINGS=()
|
|
|
|
# Check for missing platform
|
|
if ! echo "$INPUT" | grep -qE '"platform"[[:space:]]*:[[:space:]]*[0-9]'; then
|
|
WARNINGS+=("no platform assigned")
|
|
fi
|
|
|
|
# Check for missing tenant
|
|
if ! echo "$INPUT" | grep -qE '"tenant"[[:space:]]*:[[:space:]]*[0-9]'; then
|
|
WARNINGS+=("no tenant assigned")
|
|
fi
|
|
|
|
if [[ ${#WARNINGS[@]} -gt 0 ]]; then
|
|
echo "$PREFIX Device best practice: $(IFS=', '; echo "${WARNINGS[*]}") - consider assigning"
|
|
fi
|
|
fi
|
|
|
|
# Cluster creation validation
|
|
if echo "$TOOL_NAME" | grep -qE "virt_create_cluster"; then
|
|
# Check for missing site scope
|
|
if ! echo "$INPUT" | grep -qE '"site"[[:space:]]*:[[:space:]]*[0-9]'; then
|
|
echo "$PREFIX Cluster best practice: no site scope - clusters should be scoped to a site"
|
|
fi
|
|
fi
|
|
|
|
# Always allow operation (non-blocking)
|
|
exit 0
|